repos: patrickelectric: node-red: Fist commit #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick José Pereira <[email protected]>
|
Consolidate is failing because of the trailing comma here (we're handling the labels using JSON, which doesn't allow a comma after the last item in a list). |
|
Fixed. |
ES-Alexander
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
LGTM, although we should have a discussion about description lengths - if they're more than about 10 words they end up covering multiple lines in their card, which ends up looking weird in the gallery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.