Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with / Benchmarking with Asynchronous logging #130

Open
yan-hic opened this issue Aug 31, 2022 · 1 comment
Open

Compatibility with / Benchmarking with Asynchronous logging #130

yan-hic opened this issue Aug 31, 2022 · 1 comment

Comments

@yan-hic
Copy link

yan-hic commented Aug 31, 2022

How does the appender integrate with Asynchronous logging as described at https://logging.apache.org/log4j/2.x/manual/async.html#AllAsync

According to log4j doc, there is a huge performance gain but not sure if it is leveraged by log4j-s3-search.

If not,

  • is there any benefit for integrating with each other ? I assume combining both as-is would lead to buffering twice.
  • is there any plan using the core Async mechanism ?
@bluedenim
Copy link
Owner

bluedenim commented Sep 4, 2022

is there any benefit for integrating with each other? I assume combining both as-is would lead to buffering twice.

There may be some benefit in lower latency when logging. The current impl definitely did not optimize for that. There will definitely be multiple buffering involved. Currently there is already a buffer that is flushed either by size or by time. I suspect the async logging layer probably has its own buffering layer. I am pretty confident that the async layer WILL have a lower latency than what I have now.

is there any plan using the core Async mechanism?

Maybe. I'll need to learn more about that new async layer and how flexible and configurable it is. If there is a need to improve on the latency of various logging (e.g. info(), warning(), error(), etc.) calls, then that's a good motivation for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants