Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove Easydict dependency #1092

Open
iizukak opened this issue Jun 15, 2020 · 2 comments
Open

Remove Easydict dependency #1092

iizukak opened this issue Jun 15, 2020 · 2 comments

Comments

@iizukak
Copy link
Member

iizukak commented Jun 15, 2020 •
edited
Loading

We use easydict to access dictionary.
https://github.com/blue-oil/blueoil/blob/master/setup.cfg#L23

But the library longer maintenance(~2years).
https://pypi.org/project/easydict/

Maybe we should rewrite Easydict like module.

I want to remove library dependence.
@iizukak iizukak changed the title Remove easydict dependency Remove Easydict dependency Jun 15, 2020
@odoku odoku mentioned this issue Jun 16, 2020
Merged
bo-mergebot bot pushed a commit that referenced this issue Jun 25, 2020
@odoku
Implemented easydict. (#1094)
aee0301 
## What this patch does to fix the issue.

#1092
@patrick-su
Copy link
Contributor

@iizukak seems like we can close this?

@iizukak
Copy link
Member Author

iizukak commented Jul 29, 2020

@patrick-su
NO. @odoku san implement SmartDict class, but not remove easydict dependency.

@iizukak iizukak mentioned this issue Sep 28, 2020
Merged
bo-mergebot bot pushed a commit that referenced this issue Sep 28, 2020
@iizukak
Replace EasyDict to SmartDict (#1220)
8387f17 
Solve #1092 

Odoku-san implemnetd EasyDict. We can replace EasyDict to SmartDict.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iizukak @patrick-su