Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve security of the solution via e.g. MD5 checksums #9

Open
matiwinnetou opened this issue Apr 4, 2023 · 1 comment
Open

Improve security of the solution via e.g. MD5 checksums #9

matiwinnetou opened this issue Apr 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@matiwinnetou
Copy link
Collaborator

Allowing native code to run on anybody's machine is dangerous.

  1. Currently download_libs.sh doesn't contain md5 checksums. IMHO this is necessary.
  2. Ideally a developer should never add those to native folder but actually only it should be done via CI upon verification of md5 checksums

There could be other measures / ideas taken for this but the things above should be minimum, especially that project is from cryptocurrency / where trojan horses stealing things like wallet passwords are common.
@matiwinnetou matiwinnetou added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Apr 4, 2023
@matiwinnetou
Copy link
Collaborator Author

Alternatives to discuss / think about:

  • Find a way to import cargo crates into gradle project
  • Merge those two projects together: aiken-jna-wrapper and aiken-java-binding and invoke cargo via gradle tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matiwinnetou