Plugin shouldn't edit default payment button text

[eirikhr]

Regarding "Send order" button in checkout.

Line 22 in WC_Gateway_Blockonomics.php:

$this->order_button_text = __('Pay with bitcoin', 'blockonomics-bitcoin-payments');

This is unnecessary code.

It assumes two things.

• It assumes that the website owner wants to overwrite the default order button text to English language, and add "bitcoin" to the name.
• It assumes that the end user understands English.

The website owner cannot overwrite this variable in other ways, meaning the change is forced upon the website developer.

I suggest either removing the line completely, or adding it to a customizable setting variable.

[thisisayush]

@eirikhr The variable's value is translatable and can be changed by the Website Owner from WordPress Admin to any desired value and in any language with the help of any Translation Plugin, here are some more details: https://www.wpbeginner.com/wp-tutorials/how-to-translate-a-wordpress-plugin-in-your-language/

More details about __ in Wordpress: https://developer.wordpress.org/reference/functions/__/