Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TransactionPreview functionality, add console error if TP is added as an init prop #2266

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

Adamj1232
Copy link
Member

Description

Remove TransactionPreview functionality from the core package
Add console error if TP is added as an init prop
Update TP readme and docs pages

Screenshot 2024-08-05 at 13 35 53

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Copy link

@tyler-smith tyler-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Always like to see deleted code.

@Adamj1232 Adamj1232 merged commit 6e71701 into develop Aug 5, 2024
3 checks passed
@Adamj1232 Adamj1232 deleted the update/remove_transactionPreview_functionality branch August 5, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants