Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size conflict #1856

Closed
1 task done
tiago138 opened this issue Jul 31, 2023 · 4 comments
Closed
1 task done

Font size conflict #1856

tiago138 opened this issue Jul 31, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@tiago138
Copy link

Current Behavior

In our project we use rem but we define the global size of the font to font-size: 62.5%; and web3onboard app uses rem, but since it does not take in consideration that we are changing the font size the interface looks broken. And it does not seems to be possible to change some styles.
You can check how it looks on or app

Expected Behavior

Is expected that the interface does not looks broken.

Steps To Reproduce

  1. in the html tag change the font-size to 62.5%.
html {
    font-size: 62.5%;
}

What package is effected by this issue?

@web3-onboard/react

Is this a build or a runtime issue?

Runtime

Package Version

2.8.10

Node Version

18.17.0

What browsers are you seeing the problem on?

Firefox, Chrome

Relevant log output

No response

Anything else?

No response

Sanity Check

  • If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.
@tiago138 tiago138 added the bug Something isn't working label Jul 31, 2023
@leightkt
Copy link
Contributor

leightkt commented Aug 4, 2023

@tiago138 Thanks for reporting. This looks like a duplicate of #1755 ?

@tiago138
Copy link
Author

@tiago138 Thanks for reporting. This looks like a duplicate of #1755 ?

It seems to be the same problem.

@taylorjdawson
Copy link
Contributor

@tiago138 If you're okay with it, I will close this issue in leu of #1755, and you can track the conversation there 👍

@tiago138
Copy link
Author

@tiago138 If you're okay with it, I will close this issue in leu of #1755, and you can track the conversation there +1

OK, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants