From 38b4a1537a1dd32065bd1e2768005f54261fb380 Mon Sep 17 00:00:00 2001
From: Timothy Engqvist Johansson <timothy.ejohansson@gmail.com>
Date: Fri, 3 Jan 2020 23:53:12 +0100
Subject: [PATCH] Prevent submitting an invalid Pine server with keyboard

---
 src/screens/settings/ChangePineServerScreen.js | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/screens/settings/ChangePineServerScreen.js b/src/screens/settings/ChangePineServerScreen.js
index 1c696c09..4f3f6c09 100644
--- a/src/screens/settings/ChangePineServerScreen.js
+++ b/src/screens/settings/ChangePineServerScreen.js
@@ -52,7 +52,8 @@ class ChangePineServerScreen extends Component {
     super(...arguments);
 
     this.state = {
-      hostname: props.settings.pineAddressHostname
+      hostname: props.settings.pineAddressHostname,
+      canSubmit: false
     };
 
     this._onStatusUpdated = this._onStatusUpdated.bind(this);
@@ -65,7 +66,11 @@ class ChangePineServerScreen extends Component {
 
   _onSubmit() {
     const { dispatch, screenProps } = this.props;
-    const { hostname } = this.state;
+    const { hostname, canSubmit } = this.state;
+
+    if (!canSubmit) {
+      return;
+    }
 
     dispatch(saveSettings({
       pineAddressHostname: hostname
@@ -79,8 +84,10 @@ class ChangePineServerScreen extends Component {
   }
 
   _onChangeHostname(hostname) {
-    this.setState({ hostname });
-    this.props.navigation.setParams({ canSubmit: false });
+    const canSubmit = false;
+
+    this.setState({ hostname, canSubmit });
+    this.props.navigation.setParams({ canSubmit });
   }
 
   _onStatusUpdated(ok) {
@@ -89,6 +96,7 @@ class ChangePineServerScreen extends Component {
     const newHostname = this.state.hostname;
     const canSubmit = ok && newHostname !== oldHostname;
 
+    this.setState({ canSubmit });
     navigation.setParams({ canSubmit });
   }