From 6c65d71f1dbdf145a033d881be88c31410644388 Mon Sep 17 00:00:00 2001 From: Julien Fraichot Date: Tue, 6 Nov 2018 16:32:57 +0100 Subject: [PATCH] tests(Application): use more robust key for identification --- test/application/actions/shareSocialNetwork.spec.js | 2 +- test/application/actions/updateCertificateDefinition.spec.js | 4 ++-- test/application/actions/updateCertificateUrl.spec.js | 4 ++-- test/application/actions/verifyCertificate.spec.js | 2 +- test/application/domain/certificates/useCases/parse.spec.js | 2 +- test/application/domain/events/useCases/dispatch.spec.js | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test/application/actions/shareSocialNetwork.spec.js b/test/application/actions/shareSocialNetwork.spec.js index 77d035729..cfd34695b 100644 --- a/test/application/actions/shareSocialNetwork.spec.js +++ b/test/application/actions/shareSocialNetwork.spec.js @@ -26,7 +26,7 @@ describe('shareSocialNetwork action creator test suite', function () { let wasCalled = false; function assertFunction (e) { wasCalled = true; - expect(e.detail.certificateDefinition.transactionId).toEqual(validCertificate.transactionId); + expect(e.detail.certificateDefinition.id).toEqual(validCertificate.id); } window.addEventListener(CERTIFICATE_EVENTS.CERTIFICATE_SHARE, assertFunction); diff --git a/test/application/actions/updateCertificateDefinition.spec.js b/test/application/actions/updateCertificateDefinition.spec.js index 90943fb77..5bd12ab16 100644 --- a/test/application/actions/updateCertificateDefinition.spec.js +++ b/test/application/actions/updateCertificateDefinition.spec.js @@ -34,7 +34,7 @@ describe('updateCertificateDefinition action creator test suite', function () { await store.dispatch(updateCertificateDefinition(certificateFixture)); const state = store.getState(); - expect(getCertificateDefinition(state).transactionId).toEqual(validCertificate.transactionId); + expect(getCertificateDefinition(state).id).toEqual(validCertificate.id); }); it('should set the error in the state to undefined', async function () { @@ -50,7 +50,7 @@ describe('updateCertificateDefinition action creator test suite', function () { let wasCalled = false; function assertFunction (e) { wasCalled = true; - expect(e.detail.certificateDefinition.transactionId).toEqual(validCertificate.transactionId); + expect(e.detail.certificateDefinition.id).toEqual(validCertificate.id); } window.addEventListener(CERTIFICATE_EVENTS.CERTIFICATE_LOAD, assertFunction); diff --git a/test/application/actions/updateCertificateUrl.spec.js b/test/application/actions/updateCertificateUrl.spec.js index baade43f5..ba9984b39 100644 --- a/test/application/actions/updateCertificateUrl.spec.js +++ b/test/application/actions/updateCertificateUrl.spec.js @@ -62,7 +62,7 @@ describe('updateCertificateUrl action creator test suite', function () { it('should update the state with the valid certificate definition', async function () { await store.dispatch(updateCertificateUrl(MOCK_SERVER_VALID_URL)); const state = store.getState(); - expect(getCertificateDefinition(state).transactionId).toEqual(validCertificate.transactionId); + expect(getCertificateDefinition(state).id).toEqual(validCertificate.id); }); }); @@ -71,7 +71,7 @@ describe('updateCertificateUrl action creator test suite', function () { await store.dispatch(updateCertificateUrl(MOCK_SERVER_INVALID_URL)); const state = store.getState(); - expect(getCertificateDefinition(state).transactionId).toEqual(invalidCertificate.transactionId); + expect(getCertificateDefinition(state).id).toEqual(invalidCertificate.id); }); }); diff --git a/test/application/actions/verifyCertificate.spec.js b/test/application/actions/verifyCertificate.spec.js index 7683489e2..79e3ed6bb 100644 --- a/test/application/actions/verifyCertificate.spec.js +++ b/test/application/actions/verifyCertificate.spec.js @@ -46,7 +46,7 @@ describe('verifyCertificate action creator test suite', function () { let wasCalled = false; function assertFunction (e) { wasCalled = true; - expect(e.detail.certificateDefinition.transactionId).toEqual(validCertificate.transactionId); + expect(e.detail.certificateDefinition.id).toEqual(validCertificate.id); } window.addEventListener(CERTIFICATE_EVENTS.CERTIFICATE_VERIFY, assertFunction); diff --git a/test/application/domain/certificates/useCases/parse.spec.js b/test/application/domain/certificates/useCases/parse.spec.js index c60d92f01..4bc0720c2 100644 --- a/test/application/domain/certificates/useCases/parse.spec.js +++ b/test/application/domain/certificates/useCases/parse.spec.js @@ -6,7 +6,7 @@ import validCertificate from '../../../../assertions/validCertificate'; describe('domain certificates parse method test suite', function () { describe('given a valid definition of a certificate', function () { it('should return an object with a certificate definition', function () { - expect(domain.certificates.parse(certificateFixture).certificateDefinition.transactionId).toEqual(validCertificate.transactionId); + expect(domain.certificates.parse(certificateFixture).certificateDefinition.id).toEqual(validCertificate.id); }); it('should return an object with errorMessage property undefined', function () { diff --git a/test/application/domain/events/useCases/dispatch.spec.js b/test/application/domain/events/useCases/dispatch.spec.js index 402db0d7d..0e1c5741d 100644 --- a/test/application/domain/events/useCases/dispatch.spec.js +++ b/test/application/domain/events/useCases/dispatch.spec.js @@ -35,7 +35,7 @@ describe('domain events dispatch method test suite', function () { let wasCalled = false; function assertFunction (e) { wasCalled = true; - expect(e.detail.certificateDefinition.transactionId).toEqual(validCertificate.transactionId); + expect(e.detail.certificateDefinition.id).toEqual(validCertificate.id); } window.addEventListener(eventType, assertFunction);