Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalelite_post_publish.rb ignores -f parameter and transfers formats multiple times #1047

Open
defnull opened this issue Feb 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@defnull
Copy link
Contributor

defnull commented Feb 6, 2024

Describe the bug
Recording post-publish scripts are called once for each format generated by BBB, but the scalelite_post_publish.rb script ignores the -f parameter and transfers all available formats for a given recording every time it is called. If BBB is configured to produce more than one formats (e.g. presentation, video and podcast), the script will be called multiple times and transfer the early formats repeatedly, resulting in multiple imports of the same format by the Scalelite importer. The importer just replaces existing imports, so this issue only produces unnecessary work but may go unnoticed otherwise.

To Reproduce
Just look at

opts.on('-f', '--format FORMAT', 'Recording Format') do |v|
end

Expected behavior
The scalelite_post_publish.rb script should only pack and transfer the format specified by the -f parameter.

@defnull defnull added the bug Something isn't working label Feb 6, 2024
@defnull
Copy link
Contributor Author

defnull commented Feb 6, 2024

Oh, according to #888 this is more serious than I thought and causes data loss if delete_recording: true is enabled. The script is not prepared to handle multiple recording formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant