Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

January 1, 2019 fell on a Tuesday #81

Open
paatrick opened this issue Jan 8, 2019 · 2 comments
Open

January 1, 2019 fell on a Tuesday #81

paatrick opened this issue Jan 8, 2019 · 2 comments

Comments

@paatrick
Copy link

paatrick commented Jan 8, 2019

Hello,

January 1, 2019 fell on a Tuesday

In the component this appears as Monday

screen shot 2019-01-08 at 15 34 25

@loama
Copy link

loama commented Jan 16, 2019

this can be fixed by changing startNextMonthDay on rangedate-picker.js for

if (this.startNextActiveMonth > 0) {
  return new Date(this.activeYearStart, this.startNextActiveMonth, 1).getDay()
} else {
  return new Date(this.activeYearStart + 1, this.startNextActiveMonth, 1).getDay()
}

I´ll send a PR

@touchstorm
Copy link

We fixed this by adjust all the Date.UTC(...) nonsense that is going on.

return new Date(Date.UTC(this.activeYearStart, this.startNextActiveMonth, 1)).getDay(); // fails

return new Date(this.activeYearStart, this.activeMonthStart, 1, 0, 0, 0).getDay(); // good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants