Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MB-57871 - Avoid unnecessary atomic operation on bytesWritten #278

Merged
merged 1 commit into from
Oct 25, 2024
Merged

MB-57871 - Avoid unnecessary atomic operation on bytesWritten #278

merged 1 commit into from
Oct 25, 2024

Conversation

Thejas-bhat
Copy link
Member

  • the construct of bytes written while constructing a segment is not a shared resource i.e. a single thread operates on a segment creation. Hence the atomic.Add() operation is not necessary here.
  • Tested using bleve unit test with race flace
go test -run=TestBytesWritten --race
PASS
ok  	github.com/blevesearch/bleve/v2	2.294s

@abhinavdangeti abhinavdangeti merged commit ef2b41d into master Oct 25, 2024
6 checks passed
@abhinavdangeti abhinavdangeti deleted the statsCalc branch October 25, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdangeti abhinavdangeti abhinavdangeti approved these changes

@metonymic-smokey metonymic-smokey Awaiting requested review from metonymic-smokey

@CascadingRadium CascadingRadium Awaiting requested review from CascadingRadium

@Likith101 Likith101 Awaiting requested review from Likith101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thejas-bhat @abhinavdangeti