Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MB-62230 - Optimizing cluster selection in pre-filtered kNN #261

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

metonymic-smokey
Copy link
Member

@metonymic-smokey metonymic-smokey commented Sep 6, 2024

Modifies the pre-filtering kNN path for IVF indexes to factor in the distribution of filtered hits in the index.

  1. Filter the clusters which have at least one filter hit.
  2. Rank the filtered clusters in decreasing order of proximity.
  3. Pick either the closest 'nprobe' clusters or as many as needed to satisfy at least K hits, whichever comes first.
  4. Search the selected clusters for the k nearest neighbours from among the filtered hits.

There is no change in the pre-filtered search path for Flat indexes.

@metonymic-smokey metonymic-smokey changed the title Pre filter optimize MB-62230 - Optimizing cluster selection in pre-filtered kNN Sep 6, 2024
@metonymic-smokey metonymic-smokey force-pushed the pre-filter-optimize branch 2 times, most recently from 8055a78 to 1eb5f18 Compare September 9, 2024 10:00
@metonymic-smokey metonymic-smokey marked this pull request as ready for review September 9, 2024 15:11
@metonymic-smokey metonymic-smokey marked this pull request as draft September 10, 2024 03:36
@metonymic-smokey metonymic-smokey changed the base branch from pre-filter to master September 11, 2024 13:07
@metonymic-smokey metonymic-smokey changed the base branch from master to pre-filter September 11, 2024 13:07
@metonymic-smokey metonymic-smokey changed the base branch from pre-filter to master September 11, 2024 13:08
@metonymic-smokey metonymic-smokey changed the base branch from master to pre-filter September 11, 2024 13:09
@metonymic-smokey metonymic-smokey changed the base branch from pre-filter to master September 11, 2024 13:22
@metonymic-smokey metonymic-smokey marked this pull request as ready for review September 11, 2024 15:14
@abhinavdangeti abhinavdangeti merged commit f2ee767 into master Sep 19, 2024
6 checks passed
@abhinavdangeti abhinavdangeti deleted the pre-filter-optimize branch September 19, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants