-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depend on new Bitmap interface #11
base: master
Are you sure you want to change the base?
Conversation
this removes dependency on roaring bitmaps
OK, so this is the start of a multi-part proposal. The other major parts can be found here: Zapx changes (would need to be cherry-picked to all other branches as well): Bleve changes (confined to scorch): Why?
QuestionsSome of the StatusThere are some rough spots in this worth discussing further, but I wanted to float this and get an initial reaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, especially the go.mod.
@abhinavdangeti I generally agree. To me, the API package and bleve side are almost obvious improvements. The possible downside is some perf hit from type assertions in zapx code, and in one case a new allocation (slice of different type). Also, I would be interested in feedback on how I rolled the top-level |
this removes dependency on roaring bitmaps