Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openblas-build] Don't try to run openblas tests when cross compiling #117

Open
ivan-aksamentov opened this issue Feb 27, 2024 · 0 comments

Comments

@ivan-aksamentov
Copy link

ivan-aksamentov commented Feb 27, 2024

This configuration runs make targets all (explicit) and libs (coming from self.make_args()), which both try to run openblas tests from test/ and utest/ directories compiled for a foreign architecture on a host machine:

.args(&self.make_args())
.args(&self.cross_compile_args()?)
.args(["all"])

Which causes errors, because the resulting test executable cannot be ran on a host arch.

It also passes unrelated env vars - whether you cross-compiling or not, while preventing users from setting TARGET for example.

Instead, only the make target shared (confusingly named) needs to run. Users should be in control of which env vars they want to set during cross-compilation, there is no point to pick and rename the vars in this crate - it only brings confusion and bugs.

This issue makes it impossible to cross-compile the library (combined with other defects), and therefore it makes it impossible to use math libraries which rely on this crate in a production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant