Remove the makefile based build system #1967
Merged
+85
−1,361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonmux
requested changes
Oct 17, 2024
There was a problem hiding this comment.
There's one Makefile that's being removed which should not be for the moment and isn't called by the outgoing build system (it was always only ever used manually). Beyond that, this is all looking good and while melancholy to see the old system go, it is indeed starting to cause some aggravating problems and becoming a painful maintenance burden.
|
(Almost) End of an era! But what an era! |
esden
force-pushed
the
fix/remove-make-buildsystem
branch
3 times, most recently
from
544f09b
to
16d406c
Compare
We now have used meson to build BlackMagic for a while and it has proven to work well in the field. Make build system started breaking and needing maintainance effort so we decided to remove it.
esden
force-pushed
the
fix/remove-make-buildsystem
branch
from
16d406c
to
f39794b
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
As we are already using meson for a while with pretty good success and the gnu makefile based system is starting to require maintenance effort. It is time to retire the makefiles.
If it turns out that we need to bring them back for some reason it should still be relatively easy to do.
Still this is an end of an era. :)
As a side-effect this PR also deletes the libopencm3 submodule as it is not needed any more.
Your checklist for this pull request