Fix: Remote protocol packet handling organisation #1563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
In the current implementation of the GDB remote protocol in BMD, the code for processing incoming packets and dispatching based on them being actual GDB remote protocol packets or BMD remote protocol packets is kind of a mess - spaghetti code even.
This PR addresses this with a reorganisation that helps simplify the code flow and reduce cognitive complexity. This forms the basis of part of the work of PR #1361 and bringing this oft overlooked part of the code base up to standard.
Your checklist for this pull request
make PROBE_HOST=native
)make PROBE_HOST=hosted
)Closing issues