Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remote protocol packet handling organisation #1563

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

dragonmux
Copy link
Member

Detailed description

In the current implementation of the GDB remote protocol in BMD, the code for processing incoming packets and dispatching based on them being actual GDB remote protocol packets or BMD remote protocol packets is kind of a mess - spaghetti code even.

This PR addresses this with a reorganisation that helps simplify the code flow and reduce cognitive complexity. This forms the basis of part of the work of PR #1361 and bringing this oft overlooked part of the code base up to standard.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@dragonmux dragonmux added the Enhancement General project improvement label Jul 23, 2023
@dragonmux dragonmux added this to the v1.10 milestone Jul 23, 2023
@dragonmux dragonmux requested a review from esden July 23, 2023 21:53
@dragonmux dragonmux force-pushed the fix/remote-packet-handling-organisation branch from ff4db87 to 3016d1d Compare July 24, 2023 00:30
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn that was bothering me forever. Thanks for reorganizing this code.

@esden esden merged commit 7ed7816 into main Jul 26, 2023
6 checks passed
@dragonmux dragonmux deleted the fix/remote-packet-handling-organisation branch July 26, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement General project improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants