Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yara rule hostname generation bug #1768

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix yara rule hostname generation bug #1768

merged 1 commit into from
Sep 12, 2024

Conversation

liquidsec
Copy link
Collaborator

Fixes #1766

@liquidsec liquidsec changed the title fixing excavate hostname rule bug, tests, happy little accidents Fix yara rule hostname generation bug Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (4a06dc9) to head (03d4e54).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/modules/internal/excavate.py 20% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1768   +/-   ##
=====================================
- Coverage     93%     93%   -0%     
=====================================
  Files        344     344           
  Lines      26507   26507           
=====================================
- Hits       24440   24435    -5     
- Misses      2067    2072    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer merged commit 3df0cde into dev Sep 12, 2024
8 checks passed
This was referenced Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants