Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blackduck): argoCD hooks #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abdennour
Copy link

ArgoCD uses Helm just as YAML generator.
Custom ArgoCD plugins ignore helm hooks as well.

More details:
https://argo-cd.readthedocs.io/en/stable/user-guide/helm/

Signed-off-by: abdennour

@abdennour
Copy link
Author

@shehroz please FYA

@abdennour
Copy link
Author

@pcentrella FYI please

@skatzman-synopsys
Copy link

Thank you for the PR. I understand the utility for ArgoCD, but this adds specificity that doesn't apply for all use cases, customers, and scenarios. It could, however, be advantageous to provide a some form of generic annotations definition in the helper to allow customers to define annotations to meet their specific use case scenarios such as ArgoCD integration.

@abdennour
Copy link
Author

@skatzman-synopsys thank you for sparing time to review the PR. I do partially agree. Accordingly, we can add flag like .Values.managedByArgoCD and if it's "true", we should inject those annotations, instead of having it hard-coded as now.
Please let me know if this work, so i can update PR accordingly

@skatzman-synopsys
Copy link

Filed internal issue HUB-32224 to prioritize and track this change request. This pull request should remain open in alignment with HUB-32224 resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants