-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is the main controller section commented ? (common library values.yaml) #301
Comments
Hi, thanks for the nice words and raising this question! The
In most cases there is no requirement to "uncomment 250+" lines. My most complex set of values (with multiple controllers and services) is only 137 lines. |
Thanks for the clarification, those 3 reasons are now clear to me. (And by the way I recently had an issue in 2.X while trying to rename one of those default objects !) I still have a concern though, as for a beginner in helm chart/libraries (that I was some time ago...), It was very convenient to use the values.yaml file that we had until 2.6, to start testing new apps quickly. Because the file allies both most (all?) the possible attributes with explanations and references and the default objects. So this is why I mentioned that now I (or other people discovering the framework) will need to uncomment those lines if they want to keep the structure of this very "valuable" file, in order to have quick win deployments, and later spend the time to understand the library features and finally simplify the values.yaml. Maybe it's possible to have a |
I would also see some value in having some sort of |
Hello,
First, I can't thank you more for your huge contributions to the k8s / helm / flux / ... communities !
But I don't know what is the rationale for the main controller section to be commented out in the values.yaml ??
This is the case since 3.0.0-beta1.
The main use case for using the template is to run at least one controller/pod ?
And the very minimal required actions for using the common library should be to fill repo/tag/port, not to uncomment 250+ lines (even if with the correct VIM key sequence it's quite fast =D).
The text was updated successfully, but these errors were encountered: