[PM-12049] Remove usage of ActiveUserState from folder service #11880
+465
−259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate Added extra test cases for encrypted folder and decrypted folders Updated derived state to use decrypt with key
|
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11880 +/- ##
=======================================
Coverage 33.41% 33.42%
=======================================
Files 2841 2841
Lines 89008 89048 +40
Branches 16979 16990 +11
=======================================
+ Hits 29744 29762 +18
- Misses 56927 56947 +20
- Partials 2337 2339 +2 ☔ View full report in Codecov by Sentry. |
gbubemismith
commented
Nov 8, 2024
| return []; | ||
| } | ||
|
|
||
| const decryptFolderPromises = folders.map((f) => f.decryptWithKey(userKey, encryptService)); |
There was a problem hiding this comment.
ℹ️ @bitwarden/team-platform-dev changed folder decryption to use decryptWithKey instead of the decrypt method.
gbubemismith
commented
Nov 8, 2024
|
|
||
| folders$(userId$: Observable<UserId>): Observable<Folder[]> { | ||
| return userId$.pipe( | ||
| takeWhile((userId) => userId != null), |
There was a problem hiding this comment.
ℹ️ takeWhile operator to stop folder state observations when userId becomes invalid (during logout)
gbubemismith
commented
Nov 8, 2024
| this.folderViews$ = this.decryptedFoldersState.state$; | ||
| folderViews$(userId$: Observable<UserId>): Observable<FolderView[]> { | ||
| return userId$.pipe( | ||
| takeWhile((userId) => userId != null), |
There was a problem hiding this comment.
ℹ️ takeWhile operator to stop folder state observations when userId becomes invalid (during logout)
audreyality
reviewed
Nov 11, 2024
audreyality
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12049
📔 Objective
ActiveUserStateis being deprecated. Remove usage fromfolderServiceand require userId to be passed.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes