[bitnami/nginx] stream server blocks #72353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TrueGameover <[email protected]>
carrodher
added
verify
juan131
reviewed
Sep 11, 2024
bitnami/nginx/1.27/debian-12/rootfs/opt/bitnami/nginx/conf/nginx.conf
Outdated
Show resolved
Hide resolved
Signed-off-by: TrueGameover <[email protected]>
juan131
reviewed
Sep 12, 2024
| @@ -208,6 +208,10 @@ nginx_initialize() { | |||
| fi | |||
| nginx_configure "absolute_redirect" "$(is_boolean_yes "$NGINX_ENABLE_ABSOLUTE_REDIRECT" && echo "on" || echo "off" )" | |||
| nginx_configure "port_in_redirect" "$(is_boolean_yes "$NGINX_ENABLE_PORT_IN_REDIRECT" && echo "on" || echo "off" )" | |||
|
|
|||
| if [[ "${NGINX_ENABLE_STREAM}" != "no" ]]; then | |||
There was a problem hiding this comment.
You can use this instead:
Suggested change
| if [[ "${NGINX_ENABLE_STREAM}" != "no" ]]; then | |
| if is_boolean_yes "$NGINX_ENABLE_STREAM"; then |
There was a problem hiding this comment.
ok, I changed it
Signed-off-by: TrueGameover <[email protected]>
|
@TrueGameover we just released new image versions ( |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Allow autoload stream servers configs from /opt/bitnami/nginx/conf/stream_server_blocks as /opt/bitnami/nginx/conf/server_blocks
Benefits
Conveniently load stream configurations. It's not available now.
Possible drawbacks
no
Applicable issues
Additional information