Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/nats] Expose publishNotReadyAddresses on headless service #30393

Merged
merged 3 commits into from
Nov 12, 2024
Merged

[bitnami/nats] Expose publishNotReadyAddresses on headless service #30393

merged 3 commits into from
Nov 12, 2024

Conversation

rblaine95
Copy link
Contributor

@rblaine95 rblaine95 commented Nov 11, 2024 •
edited
Loading

Description of the change

  • Add the publishNotReadyAddresses config to NATS Headless Service
  • Default to false (existing behavior)

Benefits

Allow operators to specify service.headless.publishNotReadyAddresses=true if desired.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@rblaine95
[bitnami/nats] Expose publishNotReadyAddresses headless service
e22dd24 
* Add the `publishNotReadyAddresses` config to NATS Headless Service
* Default to `false` (existing behavior)

Signed-off-by: Robbie Blaine <[email protected]>
@github-actions github-actions bot added nats triage Triage is needed labels Nov 11, 2024
@bitnami-bot
Update CHANGELOG.md
d559a80 
Signed-off-by: Bitnami Containers <[email protected]>
@rblaine95 rblaine95 changed the title [bitnami/nats] Expose publishNotReadyAddresses headless service [bitnami/nats] Expose publishNotReadyAddresses on headless service Nov 11, 2024
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Nov 11, 2024
@github-actions github-actions bot removed the triage Triage is needed label Nov 11, 2024
@github-actions github-actions bot removed the request for review from javsalgar November 11, 2024 15:29
@bitnami-bot
Update CHANGELOG.md
70378bd 
Signed-off-by: Bitnami Containers <[email protected]>
juan131
juan131 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM

@juan131 juan131 merged commit 1b34ff8 into bitnami:main Nov 12, 2024
12 checks passed
@rblaine95 rblaine95 deleted the feature/nats-headless-publish-not-ready branch November 12, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan131 juan131 juan131 approved these changes

Assignees

@juan131 juan131

Labels
nats solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/nats] Expose publishNotReadyAddresses in Headless Service
5 participants
@rblaine95 @juan131 @javsalgar @carrodher @bitnami-bot