Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] Fix: external master host, disabling external access, configuration of replica when redis on the same k8s node and exposed outside by HostIP #16947

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AlehYarmalovich
Copy link
Contributor

Description of the change

These changes fixes:

  • externalMaster - if redis/sentinels and externalMaster ports are different or exposed outside.
  • When the useExternalDNS option is enabled with endpoints-type: HostIP and not set hard affinity rules, redis nodes than launch at the same k8s node as a master will be configuring as master, because equal values [[ "$REDIS_MASTER_HOST" == "$(get_full_hostname "$HOSTNAME")" ]]
  • Connecting replica when disabling external redis/sentinel access.

Benefits

This solves the issue reported here
This solves the issue reported here
This solves the issue reported here

Possible drawbacks

None from the tests I performed

  • Launched a new deployment with the sentinel.externalMaster parameter set to true.
  • Launched a new deployment with the useExternalDNS parameter set to true, endpoints-type: HostIP and pods assign on the same k8s node.
  • Launched a new deployment with the useExternalDNS parameter set to true, sentinel.service.type: NodePort and then disable external access without deliting external services.

and others tests with default values

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added the triage Triage is needed label May 29, 2023
@carrodher carrodher added verify Execute verification workflow for these changes redis labels May 29, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels May 29, 2023
@bitnami-bot bitnami-bot removed the request for review from javsalgar May 29, 2023 18:58
@bitnami-bot bitnami-bot requested a review from migruiz4 May 29, 2023 18:58
@AlehYarmalovich
Copy link
Contributor Author

@migruiz4 Do you have any updates?

Copy link
Member

@migruiz4 migruiz4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlehYarmalovich,

Could you please take a look at my comments?

bitnami/redis/values.yaml Show resolved Hide resolved
bitnami/redis/templates/scripts-configmap.yaml Outdated Show resolved Hide resolved
bitnami/redis/templates/scripts-configmap.yaml Outdated Show resolved Hide resolved
@AlehYarmalovich
Copy link
Contributor Author

@carrodher Can someone assist with the review?

@github-actions
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Jul 14, 2023
@AlehYarmalovich
Copy link
Contributor Author

@migruiz4 Do you have any updates?

@github-actions github-actions bot removed the stale 15 days without activity label Jul 15, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Aug 1, 2023
@github-actions
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Sep 11, 2023
@AlehYarmalovich
Copy link
Contributor Author

Reopen

@github-actions github-actions bot added triage Triage is needed and removed solved labels Sep 19, 2023
@carrodher carrodher reopened this Sep 19, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Sep 19, 2023
@carrodher carrodher requested review from migruiz4 and removed request for dgomezleon September 19, 2023 14:19
@carrodher carrodher assigned migruiz4 and unassigned dgomezleon Sep 19, 2023
@carrodher carrodher added on-hold Issues or Pull Requests with this label will never be considered stale and removed stale 15 days without activity labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress on-hold Issues or Pull Requests with this label will never be considered stale redis verify Execute verification workflow for these changes
Projects
None yet
6 participants