From ab7aa10a63ed0e3850577061d90c4d0db7fa696a Mon Sep 17 00:00:00 2001 From: Jasper Orschulko Date: Wed, 21 Aug 2024 18:12:16 +0200 Subject: [PATCH] [bitnami/mlflow] Update externalS3.host example AWS S3 HTTP endpoints are always regional, with `s3.amazonaws.com` defaulting to us-east-1. To avoid issues when using buckets from other regions, we should encourage including region code in the host. Fixes: https://github.com/bitnami/charts/issues/23959 Signed-off-by: Jasper Orschulko --- bitnami/mlflow/README.md | 28 ++++++++++++++-------------- bitnami/mlflow/values.yaml | 2 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/bitnami/mlflow/README.md b/bitnami/mlflow/README.md index 24f9a2b6a36105..5a76de875c6052 100644 --- a/bitnami/mlflow/README.md +++ b/bitnami/mlflow/README.md @@ -446,19 +446,19 @@ The command deploys mlflow on the Kubernetes cluster in the default configuratio ### External S3 parameters -| Name | Description | Value | -| ----------------------------------------- | ------------------------------------------------------------------ | --------------- | -| `externalS3.host` | External S3 host, e.g. "s3.amazonaws.com" | `""` | -| `externalS3.port` | External S3 port number | `443` | -| `externalS3.useCredentialsInSecret` | Whether to use a secret to store the S3 credentials | `true` | -| `externalS3.accessKeyID` | External S3 access key ID | `""` | -| `externalS3.accessKeySecret` | External S3 access key secret | `""` | -| `externalS3.existingSecret` | Name of an existing secret resource containing the S3 credentials | `""` | -| `externalS3.existingSecretAccessKeyIDKey` | Name of an existing secret key containing the S3 access key ID | `root-user` | -| `externalS3.existingSecretKeySecretKey` | Name of an existing secret key containing the S3 access key secret | `root-password` | -| `externalS3.protocol` | External S3 protocol | `https` | -| `externalS3.bucket` | External S3 bucket | `mlflow` | -| `externalS3.serveArtifacts` | Whether artifact serving is enabled | `true` | +| Name | Description | Value | +| ----------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------- | +| `externalS3.host` | External S3 host. When using AWS S3, include appropriate [regional code](https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region), e.g. "eu-central-1.amazonaws.com | `""` | +| `externalS3.port` | External S3 port number | `443` | +| `externalS3.useCredentialsInSecret` | Whether to use a secret to store the S3 credentials | `true` | +| `externalS3.accessKeyID` | External S3 access key ID | `""` | +| `externalS3.accessKeySecret` | External S3 access key secret | `""` | +| `externalS3.existingSecret` | Name of an existing secret resource containing the S3 credentials | `""` | +| `externalS3.existingSecretAccessKeyIDKey` | Name of an existing secret key containing the S3 access key ID | `root-user` | +| `externalS3.existingSecretKeySecretKey` | Name of an existing secret key containing the S3 access key secret | `root-password` | +| `externalS3.protocol` | External S3 protocol | `https` | +| `externalS3.bucket` | External S3 bucket | `mlflow` | +| `externalS3.serveArtifacts` | Whether artifact serving is enabled | `true` | The MLflow chart supports three different ways to load your files in the `run` deployment. In order of priority, they are: @@ -509,4 +509,4 @@ Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and -limitations under the License. \ No newline at end of file +limitations under the License. diff --git a/bitnami/mlflow/values.yaml b/bitnami/mlflow/values.yaml index aff74ccf34e0a8..a589b6bd6d20f4 100644 --- a/bitnami/mlflow/values.yaml +++ b/bitnami/mlflow/values.yaml @@ -1397,7 +1397,7 @@ minio: api: 80 ## @section External S3 parameters ## All of these values are only used when minio.enabled is set to false -## @param externalS3.host External S3 host, e.g. "s3.amazonaws.com" +## @param externalS3.host External S3 host. When using AWS S3, include appropriate [regional code](https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region), e.g. "eu-central-1.amazonaws.com ## @param externalS3.port External S3 port number ## @param externalS3.useCredentialsInSecret Whether to use a secret to store the S3 credentials ## @param externalS3.accessKeyID External S3 access key ID