Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved HL commander - spiral & linear segment #470

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

matejkarasek
Copy link

@matejkarasek matejkarasek commented Sep 9, 2024

This PR extends the functionality of the HL commander by adding 1) a linear option to the GOTO command and 2) a spiral command.
More details in the corresponding firmware PR: bitcraze/crazyflie-firmware#1410

@ataffanel
Copy link
Member

It seems that this PR will make the lib incompatible with previous version of the firmware.

Since the lib is currently not checking for the protocol version and locking connection, it needs to stay compatible with the old message. Either by checking the version and sending the appropriate message (maybe with a warning to update the Crazyflie), or by adding the new message in a new function.

@matejkarasek
Copy link
Author

Thanks for the review.
I see, I followed #134 where take_off was replaced by take_off_2...
Will make a new function instead 👌

@matejkarasek
Copy link
Author

matejkarasek commented Sep 25, 2024

So I made a new function.
Checking for the protocol version on the firmware side may have been more elegant, however, I have not figured out how to do that...

@knmcguire
Copy link
Member

I've just approved the CI run as that hasn't been done yet, so please check if there are any errors there.

Also for the review we'll need to try this out ourselves just to make sure that everything still works, so we will try to do that before the next release.

Yes absolutely, that would be a nice feature. I'm not sure if we have a issue/ticket for the version checking yet. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants