Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI tests for building individual packages #1018

Open
notmandatory opened this issue Jun 26, 2023 · 3 comments · May be fixed by #1575
Open

Add CI tests for building individual packages #1018

notmandatory opened this issue Jun 26, 2023 · 3 comments · May be fixed by #1575
Labels
Milestone

Comments

@notmandatory
Copy link
Member

Describe the enhancement

As described in #1017 it's possible in the build-test job for --no-default-features and --all-features tests to pass, but building individual packages can still fail.

To make sure this doesn't happen again we should test building each package individually with default, --all-features, and --no-default-features.

Use case

Catch broken feature configurations sooner.

@notmandatory notmandatory added this to the 1.0.0-beta milestone Mar 18, 2024
@oleonardolima oleonardolima linked a pull request Aug 26, 2024 that will close this issue
3 tasks
@oleonardolima
Copy link
Contributor

I gave it a try, and it doesn't seem each package can be built with --no-default-features, at least is not the case for bdk_wallet because of miniscript std/no-std requirement, see https://github.com/bitcoindevkit/bdk/actions/runs/10565729093/job/29270897594?pr=1575

@oleonardolima
Copy link
Contributor

Oh, I guess that's the reason we have the check-no-std job :think:

@notmandatory
Copy link
Member Author

I think we won't be able to fix this issue until rust-bitcoin/rust-miniscript#681 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants