Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods on the TxBuilder #418

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

thunderbiscuit
Copy link
Member

This PR brings in the methods previously available on the TxBuilder with the 0.30 release. WIP.

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@thunderbiscuit thunderbiscuit marked this pull request as draft November 17, 2023 01:27
Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 787152e

@@ -15,6 +15,8 @@ class LiveWalletTest {
val update = esploraClient.scan(wallet, 10uL, 1uL)
wallet.applyUpdate(update)
println("Balance: ${wallet.getBalance().total()}")
val balance: Balance = wallet.getBalance()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added across all 4 platforms in the follow up PR #420

@thunderbiscuit thunderbiscuit self-assigned this Nov 17, 2023
@thunderbiscuit thunderbiscuit added this to the alpha.3 milestone Nov 17, 2023
@thunderbiscuit thunderbiscuit merged commit 787152e into bitcoindevkit:master Nov 17, 2023
17 checks passed
@thunderbiscuit thunderbiscuit deleted the txbuilder branch December 7, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants