Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TxBuilder, Script, Transaction, and PartiallySignedTransaction #406

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Add TxBuilder, Script, Transaction, and PartiallySignedTransaction #406

merged 3 commits into from
Nov 6, 2023

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Oct 19, 2023 •
edited
Loading

This PR brings back some of the important types after the MVP 1.0 migration performed in #402, namely:

  • TxBuilder
  • Transaction
  • Script
  • PartiallySignedTransaction

Notes to the reviewers

The biggest change here is the use of the ScriptBuf type instead of the Script type. This is new for this codebase and I need to dig a bit more into it.

This PR also introduces a new file, bitcoin.rs, where I added the types that are coming from rust-bitcoin and reexported by bdk. In theory this should allow for a smoother transition to a bitcoin-ffi crate.

Changelog notice

APIs Added:
    - New TxBuilder type
    - New Transaction type
    - New Script type
    - New PartiallySignedTransaction type

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@thunderbiscuit thunderbiscuit changed the title Add TxBuilder Add TxBuilder, Script, Transaction, and PartiallySignedTransaction Oct 19, 2023
@thunderbiscuit thunderbiscuit self-assigned this Oct 19, 2023
@thunderbiscuit thunderbiscuit added this to the aplha.3 milestone Oct 25, 2023
@thunderbiscuit thunderbiscuit mentioned this pull request Oct 31, 2023
Merged
@thunderbiscuit
Copy link
Member Author

We should add instructions in the readme mentioning the live/offline tests.

notmandatory
notmandatory approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d37b2f3

@thunderbiscuit thunderbiscuit merged commit d37b2f3 into bitcoindevkit:master Nov 6, 2023
17 checks passed
@thunderbiscuit thunderbiscuit mentioned this pull request Nov 14, 2023
Closed
@thunderbiscuit thunderbiscuit deleted the txbuilder branch November 14, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reez reez reez approved these changes

@notmandatory notmandatory notmandatory approved these changes

Assignees

@thunderbiscuit thunderbiscuit

Labels
None yet
Projects
BDK-Bindings
Archived in project
Milestone
alpha.3
Development

Successfully merging this pull request may close these issues.
3 participants
@thunderbiscuit @notmandatory @reez