Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install instructions for Debian-based distros when dependencies are unable to be installed #353

Conversation

pablomartin4btc
Copy link
Contributor

@pablomartin4btc pablomartin4btc commented Jul 7, 2023

On earlier versions of Ubuntu 21.04 some libraries (e.g.: Qt5QmlModels) won't be deployed even requesting their installation, it requires to build the dependencies, updating the install documentation accordingly.

I've got this warning during the QML building on Ubuntu 20.04 and ofc the bitcoin-qt executable wasn't available when it finished:
configure: WARNING: Qt5QmlModels >= 5.11.3 not found; bitcoin-qt frontend will not be built

hebasto helped me to find the solution and after performing the above, managed to get it installed, up and running.

src/qml/README.md Outdated Show resolved Hide resolved
@hebasto
Copy link
Member

hebasto commented Jul 12, 2023

Concept ACK.

More general @jarolrod's suggestion looks nice as not only Ubuntu distro can be affected (Debian-based ones?).

@hebasto hebasto added the Doc Improvements or additions to documentation label Jul 12, 2023
@pablomartin4btc pablomartin4btc force-pushed the qml-install-instructions-for-old-ubuntus branch from 6b8937b to bbd092e Compare August 21, 2023 19:05
@pablomartin4btc
Copy link
Contributor Author

Agreeing with @jarolrod & @hebasto suggestions I've updated the note accordingly.

@pablomartin4btc pablomartin4btc force-pushed the qml-install-instructions-for-old-ubuntus branch from bbd092e to 40070c6 Compare August 23, 2023 13:10
@pablomartin4btc pablomartin4btc changed the title Update install instructions for earlier Ubuntu versions Update install instructions for Debian-based distros when dependencies are unable to be installed Aug 23, 2023
@pablomartin4btc pablomartin4btc force-pushed the qml-install-instructions-for-old-ubuntus branch from 40070c6 to d8ff600 Compare August 24, 2023 23:46
@hebasto
Copy link
Member

hebasto commented Aug 31, 2023

@pablomartin4btc pablomartin4btc force-pushed the qml-install-instructions-for-old-ubuntus branch from d8ff600 to 4233591 Compare August 31, 2023 23:31
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

On earlier versions of Ubuntu 21.04 some libraries ...

Confirmed this with Ubuntu 20.04. The note is useful here for first time builders of the GUI.

src/qml/README.md Outdated Show resolved Hide resolved
@pablomartin4btc pablomartin4btc force-pushed the qml-install-instructions-for-old-ubuntus branch from 4233591 to b39ad72 Compare September 8, 2023 16:20
@pablomartin4btc
Copy link
Contributor Author

Note updated.

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b39ad72

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b39ad72

src/qml/README.md Outdated Show resolved Hide resolved
On earlier versions of Ubuntu 21.04 some libraries (e.g.: Qt5QmlModels)
won't be deployed even requesting their installation,
it requires to build the dependencies, this could also
happen with other Debian-based distros so we need to
update the install documentation accordingly.
@pablomartin4btc pablomartin4btc force-pushed the qml-install-instructions-for-old-ubuntus branch from b39ad72 to d02a23c Compare September 8, 2023 23:42
@jarolrod
Copy link
Member

jarolrod commented Sep 9, 2023

ACK b39ad72

@hebasto
Copy link
Member

hebasto commented Sep 9, 2023

ACK b39ad72

Wrong hash :)

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK d02a23c.

@hebasto hebasto merged commit 216781f into bitcoin-core:main Sep 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants