Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky Setting actionItem state #341

Open
jarolrod opened this issue May 31, 2023 · 0 comments
Open

Sticky Setting actionItem state #341

jarolrod opened this issue May 31, 2023 · 0 comments
Labels
Bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@jarolrod
Copy link
Member

jarolrod commented May 31, 2023

Current behaviour

Take the About setting page for example, this is a page with multiple rows of Settings; each setting being represented by a Setting control. The Setting control is implemented to switch between different color states depending on what's happening to it at the moment (hovered, clicked, disabled, etc...). Within a Setting control, we can have an actionItem, and this actionItem will then have it's "state" tied to the parent Setting state.

It is expected that only one setting within the row would be in the HOVERED state because the mouse can only be hovered over one Setting at a time. It then follows that because a settings actionItem is tied to it's parent setting state, only one actionItem can be in a HOVERED state. But that is not the case on master if you move your mouse really quickly over all the settings. It appears that some actionItems don't get updated about their parent Setting state changing, and get stuck on an old parent state:

Screen Shot 2023-05-31 at 12 51 55 AM

Expected behaviour

Only one Setting and one actionItem should be in a state that is not "filled" or "disabled".

Steps to reproduce

Quickly run your mouse over all settings.

Relevant log output

No response

How did you obtain Bitcoin Core

Compiled from source

What version of Bitcoin Core are you using?

master

Operating system and version

macOS 12.6 M1 Pro

Machine specifications

No response

@jarolrod jarolrod added Bug Something isn't working good first issue Good for newcomers labels May 31, 2023
@jarolrod jarolrod added this to the v1.1 milestone Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant