Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App/block clock does not reflect network disconnection #324

Open
yashrajd opened this issue Apr 18, 2023 · 3 comments
Open

App/block clock does not reflect network disconnection #324

yashrajd opened this issue Apr 18, 2023 · 3 comments
Labels
Bug Something isn't working

Comments

@yashrajd
Copy link

yashrajd commented Apr 18, 2023

The application & the block clock do not display an error state when network connection is lost.

Something like this? Not sure if it is implemented.

Screenshot 2023-04-18

Actual behavior
This one is on the build from #311

Screenshot 2023-04-18

This one is from a older build.

Screenshot 2023-04-17 at 12 27 36

I've observed this more than once.

Repro: Turn off wifi when the app is running. I think it also occurred when the app is launched and the wifi is off.

Running macOS 12.5.6.

@yashrajd yashrajd added the Bug Something isn't working label Apr 18, 2023
@GBKS
Copy link
Contributor

GBKS commented Apr 19, 2023

Not sure about the technical side of this, but the design is documented here and in Figma (the "no wi-fi" state).

This should also reflect on the peers page.

image

@jarolrod
Copy link
Member

There are platform specific API's available on essentially all the platforms we support, so this can be done without needing to ping a server. Do we still want to have a specific state for when the device is simply not connected to the internet? I'm in favor of that

@GBKS
Copy link
Contributor

GBKS commented Sep 25, 2024

Yessir, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants