New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assignment expression #618

Closed

rikroe wants to merge 0 commits into bimmerconnected:master from rikroe:assignment-expression

Member

rikroe commented May 26, 2024 •

edited

Loading

Proposed change

Use assignment expressions (PEP572) as we're on minimum 3.8 anyways. This cleans up some code.

Type of change

Bugfix (non-breaking change which fixes an issue)
New feature (which adds functionality to this library)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: Unable to update charging_profile warning since 2024.5.0 home-assistant/core#116567 when merged to HA
This PR is related to issue:

Checklist

The code change is tested and works locally.
Tests have been added to verify that the new code works.

rikroe closed this

rikroe force-pushed the assignment-expression branch from cf47984 to 91c26e8 Compare

May 26, 2024 15:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet