Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move extras_require to setup.cfg #601

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Move extras_require to setup.cfg #601

merged 2 commits into from
Mar 3, 2024

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Feb 26, 2024

Proposed change

Saw a warning from pip when I tried to install bimmer-connected[china]==0.14.6 (for Home Assistant).

WARNING: bimmer-connected 0.14.6 does not provide the extra 'china'

Turns out pbr has an open bug where extras_require inside setup.py are ignored. This changed moves them to setup.cfg so it is included in the sdist / wheel metadata.
This might fix #588.

https://bugs.launchpad.net/pbr/+bug/1931705
https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#optional-dependencies

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bd4b15a) to head (e832b8c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #601   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1428      1428           
=========================================
  Hits          1428      1428           
Flag Coverage Δ
3.10 100.00% <ø> (ø)
3.11 100.00% <ø> (ø)
3.12 100.00% <ø> (ø)
3.8 100.00% <ø> (ø)
3.9 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rikroe
Copy link
Member

rikroe commented Mar 2, 2024

Thanks, didn't see that before.

I think it makes sense to also move the install_requires to setup.cfg, so there is only one place where it is defined. Would you agree?

@cdce8p
Copy link
Contributor Author

cdce8p commented Mar 3, 2024

I think it makes sense to also move the install_requires to setup.cfg, so there is only one place where it is defined. Would you agree?

Done!

Copy link
Member

@rikroe rikroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rikroe rikroe merged commit 77b4d3f into bimmerconnected:master Mar 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is BMW Connected Drive login unavailable again in China?
2 participants