Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Saw a warning from pip when I tried to install
bimmer-connected[china]==0.14.6
(for Home Assistant).Turns out
pbr
has an open bug whereextras_require
insidesetup.py
are ignored. This changed moves them tosetup.cfg
so it is included in the sdist / wheel metadata.This might fix #588.
https://bugs.launchpad.net/pbr/+bug/1931705
https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#optional-dependencies
Type of change
Additional information
Checklist