Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default debug logging, allow status for one VIN only #598

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Feb 11, 2024

Proposed change

  • Disables default debug logging on CLI. Can be printed using bimmerconnected --debug status ...
  • Adds option to return only one vehicle for status using bimmerconnected status --vin VIN ...

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe requested a review from gerard33 February 11, 2024 18:46
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (770524a) 100.00% compared to head (6d70d82) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #598   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1428      1428           
=========================================
  Hits          1428      1428           
Flag Coverage Δ
3.10 100.00% <ø> (ø)
3.11 100.00% <ø> (ø)
3.12 100.00% <ø> (ø)
3.8 100.00% <ø> (ø)
3.9 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gerard33 gerard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rikroe rikroe merged commit f59746b into bimmerconnected:master Feb 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants