Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ConnectedDriveAccount/Vehicle #556

Merged

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Aug 9, 2023

Breaking change

This PR removes the deprecated ConnectedDriveAccount/ConnectedDriveVehicle classes and all corresponding attributes.
Please use only MyBMWAccount/MyBMWVehicle going forward.

Proposed change

See breaking change, clean up.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b27e299) 100.00% compared to head (4781922) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #556    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           18        17     -1     
  Lines         1504      1328   -176     
==========================================
- Hits          1504      1328   -176     
Flag Coverage Δ
3.10 100.00% <100.00%> (ø)
3.11 100.00% <100.00%> (ø)
3.7 100.00% <100.00%> (ø)
3.8 100.00% <100.00%> (ø)
3.9 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
bimmer_connected/account.py 100.00% <ø> (ø)
bimmer_connected/vehicle/__init__.py 100.00% <100.00%> (ø)
bimmer_connected/vehicle/vehicle.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rikroe rikroe requested a review from gerard33 August 9, 2023 20:45
@rikroe rikroe merged commit dac1219 into bimmerconnected:master Aug 10, 2023
13 checks passed
@rikroe rikroe deleted the remove-deprecated-connecteddrive branch October 20, 2023 20:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants