Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should not be possible to turn off country rules #122

Open
graue opened this issue May 15, 2023 · 0 comments
Open

It should not be possible to turn off country rules #122

graue opened this issue May 15, 2023 · 0 comments
Assignees

Comments

@graue
Copy link

graue commented May 15, 2023

Currently, as in upstream GraphHopper (at the time we forked, anyway), country rules are disabled by default, but our Bay Area config in this repo turns them on.

To interpret cycleway:left and cycleway:right tags, the router needs to know the driving side, which it gets only from country rules. Therefore, correct operation requires country rules and they should not be disabled by default, nor should the feature to disable them exist. Ideally we would merge this change into upstream (which is also currently failing to handle cycleway:left and cycleway:right at all).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants