Bug 2676 pre submit custom validation v1 #2830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separated 'should include in form submission' from 'should validate as part of form submission' to ensure custom validation hooks are still evaluated on unchecked checkboxes and radiogroups without a selection.
Corresponding issue: #2676
Testing
Tested manually using the replication sample attached to the ticket. Added automated tests without the fix to demonstrate the problem, and then restored the fix and checked that the failing tests now passed.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded