Cleaner Bootstrap 5 modals example. #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekoza
changed the title
|
hey @dekoza can you retarget this at |
|
@dekoza I'm sorry for the delay on this, if you rebase and ping me we'll get it looked at. |
dekoza
force-pushed
the
bootstrap_example
branch
2 times, most recently
from
2d6eb0a
to
7b44393
Compare
dekoza
force-pushed
the
bootstrap_example
branch
from
7b44393
to
acb6005
Compare
|
@1cg @alexpetros I think I managed to update this properly 😉 |
alexpetros
added
the
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some experimentation I managed to get htmx working smoothly with Bootstrap 5 modals and their original JS bundle.
Edit:
OK, got it working after few tries. Turns out the initial skeleton needs to be a bit bigger. But it doesn't require writing any JS or even using hyperscript 🙂