test(component): refactor collapse component tests #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-alexsaiannyi
force-pushed
the
bigdesign-635-collapse
branch
from
251491a
to
1156df0
Compare
chanceaclark
approved these changes
Dec 3, 2021
| const icon = trigger.querySelector('svg'); | ||
| render(CollapseWithStaticTitleMock); | ||
|
|
||
| const icon = screen.getByRole('button').querySelector('svg'); |
There was a problem hiding this comment.
🍹 Using querySelector to get the SVG is a little concerning. It might mean that we need to add a role to the image for accessibility, potentially along with any additional aria tags 🤔
No action needed for this, just pointing out that if we are using querySelector something might be wrong.
bc-apostoliuk
approved these changes
May 6, 2022
eugene-polev
approved these changes
May 6, 2022
bc-alexsaiannyi
force-pushed
the
bigdesign-635-collapse
branch
from
1156df0
to
e019ebb
Compare
bc-juanvasquez
pushed a commit
to bc-juanvasquez/big-design
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is aimed to refactor Collapse component's tests according to best practices. We take into account recommendations from Kent C. Dodds article. For instance, using
containerforquery-ing elements has been removed. Instead, we replace it withscreen.NOTE: userEvent package has been added for switching over fireEvent.
Why?
the changes are based on GitHub issue and PRs will be open for each component separately.
Testing/Proof
The tests have been successfully run locally.