test(component): refactor Box component tests #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,91 +8,89 @@ import { render } from '@test/utils'; | |||
| import { Box } from './index'; | |||
|
|
|||
| test('has margin props', () => { | |||
| const { container, rerender } = render(<Box />); | |||
| const { rerender } = render(<Box data-testid="box" />); | |||
There was a problem hiding this comment.
Hmmm... 🤔 we should probably avoid using data-testid unless it's absolutely needed.
Maybe we can add some text and query that?
const { rerender } = render(<Box>test</Box>); // screen.getByText('test');There was a problem hiding this comment.
I think its a good way to use the most appropriate queries. Changed all over the component and updated snapshots
yurytut1993
force-pushed
the
bigdesign-635-box
branch
from
ef09976
to
ddd87cf
Compare
chanceaclark
approved these changes
Dec 3, 2021
yurytut1993
force-pushed
the
bigdesign-635-box
branch
from
486fe67
to
170a2eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is aimed to refactor Box component's tests according to best practices. We take into account recommendations from Kent C. Dodds article. For instance, using
containerforquery-ing elements has been removed. Instead, we replace it withscreen.Why?
the changes are based on GitHub issue and PRs will be open for each component separately.
Testing/Proof
The tests have been successfully run locally.