Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spacing BD values for FlexGap, GridGap, etc #912

Open
MariaJose opened this issue Jul 13, 2022 · 0 comments
Open

Use spacing BD values for FlexGap, GridGap, etc #912

MariaJose opened this issue Jul 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@MariaJose
Copy link
Contributor

MariaJose commented Jul 13, 2022

Is your feature request related to a problem? Please describe.
Right now we are using css values for FlexGap, GridGap, etc. However, would be good to use BD spacing values when using this props for Flex and Grid components.

Describe the solution, feature, or improvement you'd like
Use Spacing BD values for FlexGap, FlexColumnGap, FlexRowGap, GridGap, GridColumnGap, and GridRowGap props.

References:
Spacing values in BD: https://developer.bigcommerce.com/big-design/spacing
Flex component: https://developer.bigcommerce.com/big-design/flex
Grid component: https://developer.bigcommerce.com/big-design/grid

Example:

How it can be used for now:

<Flex flexGap="1rem" />

Suggestion:

<Flex flexGap="small" />
@MariaJose MariaJose added the enhancement New feature or request label Jul 13, 2022
@MariaJose MariaJose changed the title Use spacing props for FlexGap, GridGap, etc Use spacing BD values for FlexGap, GridGap, etc Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant