Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input has a width prop #802

Open
jorgemoya opened this issue Apr 28, 2022 · 2 comments
Open

Input has a width prop #802

jorgemoya opened this issue Apr 28, 2022 · 2 comments
Labels
bug Something isn't working types Issues with Typescript types

Comments

@jorgemoya
Copy link
Contributor

Input accepts a width prop (via React.InputHTMLAttributes<HTMLInputElement>), that is not actually used (width is set as 100%). We either need to fix this type OR actually allow a width prop to the input, which seems convenient to me. We should do this as well for selects.

Wanted to open this for discussion.
@jorgemoya jorgemoya added bug Something isn't working types Issues with Typescript types labels Apr 28, 2022
@MariaJose
Copy link
Contributor

Thanks for reporting this!! Good catch! I think we should fix the type? I think would be good to let the input component follow its parent width?

@jorgemoya
Copy link
Contributor Author

I'm good with that

@MariaJose MariaJose assigned MariaJose and unassigned MariaJose Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working types Issues with Typescript types
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jorgemoya @MariaJose