Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting method 'case-insensitive' #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bartholomej
Copy link

@bartholomej bartholomej commented Jul 31, 2020

There is a new option for sorting.

What is in this PR?

  • New parameter (--sort case-insensitive) is available
  • Updated readme
  • Updated tests
  • No breaking changes because default option --sort (without parameter) is the same as it was

Why?

It can be useful when you are using one of the online i18n services (e.g. Phrase, Crowdin, ...), which export alphabetically sorted translations (but in case insensitive mode).
The output from ngx-translate-extract will therefore be compatible, easier to merge and git diff will be much clearer.

Examples

--sort (default js .sort() is case sensitive)

{
  "9": "9",
  "88": "88",
  "Bat": "Bat",
  "ZZ-top": "ZZ-top",
  "ast": "ast"
}

--sort case-insensitive (new method)

{
  "9": "9",
  "88": "88",
  "ast": "ast",
  "Bat": "Bat",
  "ZZ-top": "ZZ-top"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant