Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator should alert about mismatch between participants.tsv's participant_id column and subject folders #1674

Open
dungscout96 opened this issue May 15, 2023 · 2 comments

Comments

@dungscout96
Copy link

dungscout96 commented May 15, 2023

participants.tsv in dataset ds003620 has illegal participant_id values as the first 9 subject IDs doesn't have the leading 0. Should it not pass the validator.
Similar issue for ds003800

@dungscout96 dungscout96 changed the title Dataset with illegal subject_id in participants.tsv passed the validator Datasets with illegal subject_id in participants.tsv passed the validator May 15, 2023
@sappelhoff
Copy link
Member

Thanks for the bug report.

The mismatch between what's listed under participant_id in participants.tsv and the actual subject directories seems like something we should raise an error for.

Taking ds003800 as a showcase in the screenshots below:

image

see the missing leading zeros:

image

@sappelhoff sappelhoff changed the title Datasets with illegal subject_id in participants.tsv passed the validator Validator should alert about mismatch between participants.tsv's participant_id column and subject folders May 30, 2023
@sappelhoff sappelhoff added the bug label May 30, 2023
@effigies
Copy link
Collaborator

Resolved in schema validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants