-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eye2bids classifying StartTime and StopTime metadata as arrays rather than numbers [BUG] #96
Comments
Ok I suspect that the start and stop of each "trial" should logged in the physioevents rather than the Metadata of the physio eyetracking. |
It is currently listed as metadata for the _recording-_physio.json. You remember, we had this pain with making sure that only the first StartTime and the last StopTime is recorded in the json because when they stop the eyetracker in between the asc file has multiple. But yes, starts and stops of each trial are logged in the physioevents but this is not what Dan means, I think, but the recorded Start and Stop Time in the physio.json are the ones corresponding to one run. @dlevitas I will fix it, this is a residual from the time when we still allowed multiple Start/StopTimes in the metadata and we put them in an array. However, now that we only allow one it should be a number. |
PR #98 |
eye2bids (version
0.1.dev84+gf49a08f
) injects theStartTime
andStopTime
metadata fields as arrays rather than numbers, which appear to be improper (e.g. here).cc @julia-pfarr @Remi-Gau
The text was updated successfully, but these errors were encountered: