Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a message on no errors or warnings #93

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Show a message on no errors or warnings #93

merged 3 commits into from
Nov 11, 2024

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Nov 7, 2024

No description provided.

@rwblair
Copy link
Member Author

rwblair commented Nov 7, 2024

I don't feel great about the confetti dependency, we can remove it if need be.

@rwblair
Copy link
Member Author

rwblair commented Nov 7, 2024

Alternative to confetti npm package:
https://stackoverflow.blog/2021/05/31/shipping-confetti-to-stack-overflows-design-system/

effigies
effigies approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no complaints whatsoever.

@effigies effigies changed the base branch from main to stable November 8, 2024 21:30
@effigies effigies merged commit f4bb6e2 into bids-standard:stable Nov 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwblair @effigies