Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intended for does not cover qMRI cases #157

Open
Remi-Gau opened this issue Feb 18, 2021 · 2 comments
Open

Intended for does not cover qMRI cases #157

Remi-Gau opened this issue Feb 18, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@Remi-Gau
Copy link
Collaborator

Sorry to reopening the request. There two issues that I encountered during the tests:

  1. Do not take into account qMRI fieldmaps (TB1EPI etc...)
  2. The json list in IntendedFor is transformed into cell and not structure, hence it avoid elseif on line 527
ans =

  6x1 cell array

    {'anat/sub-HC1278_echo-*_acq-T1w_part-phase_MPM.nii.gz'  }
    {'anat/sub-HC1278_echo-*_acq-T1w_part-mag_MPM.nii.gz'    }
    {'anat/sub-HC1278_echo-*_acq-MToff_part-mag_MPM.nii.gz'  }
    {'anat/sub-HC1278_echo-*_acq-MToff_part-phase_MPM.nii.gz'}
    {'anat/sub-HC1278_echo-*_acq-MTon_part-mag_MPM.nii.gz'   }
    {'anat/sub-HC1278_echo-*_acq-MTon_part-phase_MPM.nii.gz' }

Proposition of solution (not sure if it will broke something else):
1a) Search IntendedFor in each of json files
1b) Search IntendedFor in each file in modality fmap, not sure how it will work for coodsystem and m0

Originally posted by @nbeliy in #151 (comment)

@Remi-Gau
Copy link
Collaborator Author

1b) Search IntendedFor in each file in modality fmap, not sure how it will work for coodsystem and m0

Ah thanks.
As the qMRI examples are not yet in the bids-examples repo I had overlooked this.

Yeah I think the best is to check all the files in fmap. Will fix this.

@Remi-Gau
Copy link
Collaborator Author

Yeah I think the best is to check all the files in fmap. Will fix this.

ha but if we do that then we end up with all the files in fmap being listed... OK need to think about this a bit.

@Remi-Gau Remi-Gau added the bug Something isn't working label Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Wish list
Development

No branches or pull requests

1 participant