Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output from clinica t1freesurfer pipeline #313

Closed

Conversation

omar-rifai
Copy link

Hello,

This is a small example of an output that could be obtained from the "t1freesurfer" pipeline from Clinica. Currently the directory hierarchy is a bit different but we are aiming towards ensuring compliance with this example. This would illustrate how FreeSurfer's recon-all output (and some additional files) could be organized into BIDS.

@effigies
Copy link
Contributor

Thanks for the proposal! Along with examples, it's a good idea to write up the structure to give people a chance to comment on it. To get started, see the BIDS Extension Proposal Guide.

I'm going to convert this to a draft, as we won't be able to merge this until the structure is specified and validatable.

@effigies effigies marked this pull request as draft April 19, 2022 12:52
@omar-rifai
Copy link
Author

Hello @effigies, thanks for the feedback. I'm not sure I understand what you mean by structure?

Maybe the initial description was not very clear but the purpose of this example is just to illustrate an example of an output that should already be handled by the current BIDS derivative specification.

In the same vein as PR309, the aim for it is to serve as a basis for discussion for the upcoming bids-provenance proposal.

I'll have a look at the errors returned by the validator and please let me know if I need to add/change anything else.

Thanks

@effigies
Copy link
Contributor

I see. I would say that these do not look like currently-defined BIDS derivatives to me:

clinica-freesurfer/sub-01/ses-2011/freesurfer/sub-01_ses-2011_freesurfer/label/BA_exvivo.ctab
...
clinica-freesurfer/sub-01/ses-2011/freesurfer/sub-01_ses-2011_parcellation-ba_area.tsv
clinica-freesurfer/sub-01/ses-2011/freesurfer/sub-01_ses-2011_parcellation-ba_meancurv.tsv
...

This is proposing a new datatype of "freesurfer", new suffixes including "freesurfer", "area" and "meancurv", a new entity "parcellation". And the suffix "freesurfer" appears to correspond to a FreeSurfer subject reconstruction directory.

This is not to say your proposal is unreasonable, but it is not part of the current standard and will need to be discussed before simply merging into examples. The document I linked above outlines the proposal, both for smaller ones that can be done as individual PRs into the specification and larger ones that usually go through a period of a stand-alone Google Doc for easier contribution.

@omar-rifai
Copy link
Author

Understood. will look into the above mentioned points and try to come up with a proper proposal.

Thank you.

@sappelhoff
Copy link
Member

@sappelhoff sappelhoff closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants