-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with conda-forge #38
Comments
Some things while digging around:
Again, still no closer to having you your upstreams on |
Happy to change
Agreed, I can remove it from juypter-cadquery
That's a bug, will remove it
Happy to add cadquery 2.1 to extra requires. I didn't need it up to now since it is not on pypi as you said If I do these changes, would I then need to deploy both packages with newer versions (2.0.3 for jupyter-cadquery-widgets and 2.0.1 for jupyter-cadquery) or would it be sufficient to have the changes in master? |
since i can't package your stuff anyway yet, no need to publish! |
I notice that the jupyter-cadquery v3 has a different dependency stack, is it worth taking another look conda-forge deployment |
@shimwell What would be your requirements? One of the biggest issues I have is that CadQuery doesn't have versions or tags. In order to participate on features like |
I am able to install into a conda environment nicely However I am quite keen to build a conda package that makes use of jupyter-cadquery and I think that when making a conda package all dependencies must also be available on conda. Therefore I can't include jupyter-cadquery in the package I am currently making. The meta.yml for my package is here and you can see I have jupyter-cadquery commented out. So currently I have a two part install process which is conda install my package (this brings in cadquery and others) then pip install jupyter_cadquery. I guess on the cadquery front that lack of tag will be solved once cadquery 2.2 is released. I wonder if in theory jupyter-cadquery could be published to either conda-forge channel, cadquery channel or another channel? I have a package on conda that makes use of the master branch of cadquery which appears to bring in the version tagged as master |
I have never built a conda package, so I first need to understand how to do so.
btw. my problem around cadquery=master is for the docker container. I artificially need to change something else in my Dockerfile in order to pick up the latest CadQuery master. In general I would prefer to pin the version to a version I have tested it on. But, no tags exist ... |
I will also take inspiration from your conda packages and meta.yaml files ... |
I recall there was a reason that CadQuery2 is in a dedicated channel and noticed this issue that might be of interest I think conda-forge packages need all their dependencies to be on conda forge so perhaps I should ask this question over on cadquery repo first |
Good point. |
Since cadquery is available in pypi now, this is not necessary any more from my point of view |
Add jupyter-cadquery to conda-forge
The text was updated successfully, but these errors were encountered: